Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplet S2 perception #778

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Conversation

alongd
Copy link
Member

@alongd alongd commented Dec 7, 2024

Fixes an issue with perceiving S2 as a triplet from xyz, building upon #756
tests added

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (84898ee) to head (92bbc31).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   74.03%   74.06%   +0.02%     
==========================================
  Files         101      101              
  Lines       28030    28046      +16     
  Branches     5870     5872       +2     
==========================================
+ Hits        20752    20771      +19     
+ Misses       5803     5802       -1     
+ Partials     1475     1473       -2     
Flag Coverage Δ
unittests 74.06% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alongd alongd requested a review from calvinp0 December 7, 2024 22:10
@alongd alongd merged commit 6fda63e into ReactionMechanismGenerator:main Dec 8, 2024
6 of 7 checks passed
@alongd alongd deleted the S2_per branch December 8, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants