Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the normal mode displacement TS check #768

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
+13,565 −90,773

tmp - mod cache

cd4c959
Select commit
Loading
Failed to load commit list.
Open

Fix the normal mode displacement TS check #768

tmp - mod cache
cd4c959
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 5, 2025 in 1s

75.28% (+1.24%) compared to 66134b3

View this Pull Request on Codecov

75.28% (+1.24%) compared to 66134b3

Details

Codecov Report

Attention: Patch coverage is 92.88762% with 50 lines in your changes missing coverage. Please review.

Project coverage is 75.28%. Comparing base (66134b3) to head (cd4c959).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
arc/checks/nmd.py 89.11% 13 Missing and 8 partials ⚠️
arc/scheduler.py 8.33% 11 Missing ⚠️
arc/species/species.py 69.23% 6 Missing and 2 partials ⚠️
arc/checks/ts.py 62.50% 1 Missing and 2 partials ⚠️
arc/species/converter.py 91.17% 3 Missing ⚠️
arc/checks/nmd_test.py 99.25% 1 Missing and 1 partial ⚠️
arc/reaction.py 96.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   74.03%   75.28%   +1.24%     
==========================================
  Files         101      103       +2     
  Lines       28030    29480    +1450     
  Branches     5870     6322     +452     
==========================================
+ Hits        20752    22194    +1442     
- Misses       5803     5812       +9     
+ Partials     1475     1474       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov