Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ase to version 3.22.1 #755

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fixed ase to version 3.22.1 #755

merged 1 commit into from
Jul 4, 2024

Conversation

kfir4444
Copy link
Collaborator

@kfir4444 kfir4444 commented Jul 3, 2024

otherwise it cannot solve the env

otherwise it cannot solve the env
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.67%. Comparing base (298fe33) to head (6007cb9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files          99       99           
  Lines       27418    27418           
  Branches     5771     5771           
=======================================
  Hits        20200    20200           
  Misses       5769     5769           
  Partials     1449     1449           
Flag Coverage Δ
unittests 73.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@calvinp0 calvinp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@kfir4444 kfir4444 merged commit 8b3b841 into main Jul 4, 2024
7 checks passed
@kfir4444 kfir4444 deleted the ase_fix_2 branch July 4, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants