Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a module for working with RMG reaction families #754

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
+4,436 −3,171

f rxn

cb31f72
Select commit
Loading
Failed to load commit list.
Open

Added a module for working with RMG reaction families #754

f rxn
cb31f72
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Jan 12, 2025 in 6s

15 new alerts including 3 errors

New alerts in code changed by this pull request

  • 3 errors
  • 12 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 453 in arc/checks/ts_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 526 in arc/checks/ts_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 652 in arc/checks/ts_test.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check failure on line 17 in arc/family/family.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'ARCReaction' may not be defined if module
arc.reaction.reaction
Loading
is imported before module
arc.family.family
Loading
, as the
definition
Loading
of ARCReaction occurs after the cyclic
import
Loading
of arc.family.family.

Check notice on line 894 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 894 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.

Check notice on line 898 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 898 in arc/mapping/engine.py

See this annotation in the file changed.

Code scanning / CodeQL

Except block handles 'BaseException' Note

Except block directly handles BaseException.

Check notice on line 5 in arc/plotter.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'math' is not used.

Check notice on line 911 in arc/plotter.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 5 in arc/processor.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'math' is not used.

Check failure on line 13 in arc/reaction/reaction.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'ReactionFamily' may not be defined if module
arc.family.family
Loading
is imported before module
arc.reaction.reaction
Loading
, as the
definition
Loading
of ReactionFamily occurs after the cyclic
import
Loading
of arc.reaction.reaction.

Check failure on line 13 in arc/reaction/reaction.py

See this annotation in the file changed.

Code scanning / CodeQL

Module-level cyclic import Error

'get_reaction_family_products' may not be defined if module
arc.family.family
Loading
is imported before module
arc.reaction.reaction
Loading
, as the
definition
Loading
of get_reaction_family_products occurs after the cyclic
import
Loading
of arc.reaction.reaction.

Check notice on line 15 in arc/scripts/rmg_kinetics.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'TemplateReaction' is not used.

Check notice on line 19 in arc/scripts/rmg_kinetics.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'get_family_library_object' is not used.