-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
January 2021 Update #37
Conversation
Please note that for this to work, Member intent has to be enabled on Discord DevPortal as demonstrated in #developer_spot. |
Also, @jmk-developer suggested that we might want to redesign the layout of My current proposal is a layout like this
where libs with a strike means dead libs. I am thinking, should we keep those dead libs in In the future, we might just migrate the list in |
Has been enabled.
I do think that it needs a redesign but, striking out libraries as opposed to not having them in the list takes up a lot of unneeded space for seemingly no reason. I think the best course of action would be a command like:
|
If I want to create a new python file, is there anything need to change on The new code heavily relies on |
Also can we create a |
Except data and logging, which are omg
Code refactor is completed. Now it's just the matter of whether to update this or not.
Can you give me a demo response in Markdown? |
Generates static files. If you have a static file that needs to be generated on restart (i.e re-cached) then, it makes sense to add it here. Otherwise, the file will not update. https://github.com/RbxAPI/Docs-Bot/blob/rewrite/generate.py#L57
Probably a good idea.
Sure. Karen: ?libs python
Karen: ?libs js
Something like this that is simple but, gets the job done. |
So we are purging dead libs? |
I hope so 😞 |
I think it should only mention the channel name in the field value and only have the repo link & name as the title of each field |
Correct. I think that the linked author name is a bit redundant. I think it should just be renamed to
Provide a visual representation as to what this means. |
Supports multi-author. This should be the final format. @jmkd3v |
Okay, looks great! Glad we can both get credit for our work. Excited to see this implemented soon! |
Right. Everything is set besides the above "rename EmbedFactory" thing |
Wat why is there conflicting files |
Sanjay seems to have modified main.py which you also modified? |
yep just realised he pushed something |
Resolved file conflicts. |
Completing some internal things to make this PR easier to put into life. Will be a bit. |
Any update on when this will be pushed to main? |
Couple days. I'm trying to fix / improve some core stuff before I push this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my end. Thanks for the PR. Merging.
+ Added ro.py in
libs.yml
+ Many embed that displayed a member's name/discriminator/id now directly mentions the member.
* Code refactor and clean up.
+ Redesign
?libs
moderation.py
A large amount of code has been extracted to 2 methods.
* Fixed a bug which Moderators with no Library Developer role can't invoke moderation commands
^ Many commands now work.
I didn't test ?reason ?duration as I didn't have the database on my working dir.