Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache export and import #33

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix: cache export and import #33

merged 1 commit into from
Feb 23, 2023

Conversation

mhchia
Copy link
Member

@mhchia mhchia commented Feb 23, 2023

What's the PR for?

  • Fix export: stringify bigints before JSON.stringify, otherwise JSON.stringify might throw error if cache contains bigints
  • Fix import: parse exported JSON string and initialize Cache

Fixes #31.

@AtHeartEngineer AtHeartEngineer merged commit c20d6a2 into main Feb 23, 2023
@mhchia mhchia deleted the fix/cache-import branch February 23, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache.import returns an Object instead of a Cache
2 participants