Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raspap.sudoers #1111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update raspap.sudoers #1111

wants to merge 2 commits into from

Conversation

smartmarmot
Copy link

The command launched here: https://github.com/smartmarmot/raspap-webgui/blob/4299d4d7ccfe1da42d7505a47ffa03ad542ddbc4/includes/openvpn.php#L153
is actually /bin/ln I've had to manually fix it on raspberry pi bullseye

the command launched here: https://github.com/smartmarmot/raspap-webgui/blob/4299d4d7ccfe1da42d7505a47ffa03ad542ddbc4/includes/openvpn.php#L153
is actually /bin/ln I've had to manually fix it on raspberry pi bullseye
@smartmarmot
Copy link
Author

smartmarmot commented Jan 27, 2022

I've tested this on two freshly build bullseye and it fails when you enable one of the configurations, now this is fixed.
Anyway I think that most likely use the full path would be a better option so actually recode the web UI that calls the shell commands. What do you think about?

@billz
Copy link
Member

billz commented Jan 24, 2023

I wasn't able to repro this behavior on Debian 11 (bullseye).

From what I understand, PHP's system() call functions like the C version.

The PHP docs lack detail on this, but the POSIX / ISO C standard on which it's based uses examples without absolute paths. Probably for better portability(?)

The POSIX system() function passes string to the sh shell command for execution.
A string with TSO/E command line syntax:

command_name parm1 parm2 … 

Example:
system("user_pgm1 1234 abcd xyz");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants