Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jest Coverage에 대한 push 제한 처리 #25

Merged
merged 7 commits into from
Jun 22, 2024

Conversation

d0422
Copy link
Member

@d0422 d0422 commented Jun 20, 2024

  • jest Coverage에 대한 push 제한처리
  • Contributing 문서 업데이트
  • jest:coverage 명령어 husky pre-push에 등록

jest Coverage 정책 추가

라이브러리 품질 보증을 위해 현재 branch 80, functions 80, lines 100으로 threshold를 지정하였습니다.
추후에 모두 100%로 만들예정이며, 현재, 해당 기준을 만족하지 못하는 useScrollRatio를 임시 삭제하였습니다.

#26 에 해당 이슈를 남겨두었습니다.

@d0422 d0422 requested a review from HBSPS June 20, 2024 08:01
@d0422 d0422 self-assigned this Jun 20, 2024
@d0422 d0422 added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 20, 2024
Copy link
Contributor

@HBSPS HBSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Comment on lines +18 to +24
coverageThreshold: {
'src/**/*.{ts,tsx}': {
branches: 80,
functions: 80,
lines: 100,
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 수 배워갑니다!

@d0422 d0422 merged commit 8bebdb2 into Rapiders:main Jun 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants