feat: develop useSwitch custom hook #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
앞으로는 어떤 형식으로 기여를 해야할까요? CONTRIBUTING 문서가 있으면 좋을 것 같네요 |
d0422
reviewed
May 26, 2024
src/useBoolean/useBoolean.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| import { useState } from 'react'; | |||
|
|
|||
| export type UseSwitchReturn = ReturnType<typeof useBoolean>; | |||
There was a problem hiding this comment.
혹시 여기 따로 타입지 정을 해주신 이유가 있을까용?
useSwitch 와 useBoolean모두 UseSwitchReturn이라는 이름으로 타입이 기재되어있어서 여쭤봅니다!
src/stories/useSwitch/Switch.css
Outdated
There was a problem hiding this comment.
Storybook 내부적으로 css 속성들이 겹치는 문제가 발생해서 vanilla extract를 도입하였는데요, 혹시 괜찮으시면 이후에 이 부분 내용이 바뀌어도 괜찮으신지 여쭤보고 싶습니다...!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
다음 2가지 훅이 추가되었습니다.
useBoolean
useSwitch, useDisclosure 등 true-false 상태를 가지는 컴포넌트를 구현하는데 기초가 되는 훅입니다.
useSwitch
켜고 끌 수 있는 스위치(=토글)에 사용되는 훅입니다. (참고)
useBoolean에 종속적입니다.
자세한 설명은 storybook 참고 부탁드립니다.