Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for SMSCB #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ervteng
Copy link

@ervteng ervteng commented Jun 11, 2014

These fixes were necessary for me to get SMSCB working properly. Props to Chuck Bokath and Donald Kirker for the discussion on OpenBTS-Discuss that led to these changes.

Changed hardcoded language code in SMSCB.cpp to 0x01, which is English in the default GSM encoding, which fixes some display errors, especially on Android phones.

The fourth L2 CBCH frame in an SMSCB message now has the Last Block Bit properly set.

GSMTAP now properly reports SMSCB messages, and Wireshark shows the messages as expected.

ervteng added 2 commits June 11, 2014 16:07
…isplays properly on Android devices, and corresponds to English.
…t to 0x03, corresponding to the end of the SMSCB message. GSM 04.12

Also, added SMSCB as a GSMTAP type, so it is recognized by Wireshark.
@iedemam
Copy link
Member

iedemam commented Jun 12, 2014

Hi Ervin,

Nice work! Glad you could turn this into a pull request. It's a great find to have fixed. We're still trying to get CLAs automated on GitHub but until then it's a manual process. I'll e-mail you the document.

Changed SMSCB behavior so that messages are not sent until send_time is reached.
yaka-es pushed a commit to yaka-es/OpenBTS that referenced this pull request Nov 3, 2017
yaka-es pushed a commit to yaka-es/OpenBTS that referenced this pull request Nov 3, 2017
@fulvous fulvous mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants