Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and refactor project #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kgromov
Copy link

@kgromov kgromov commented Feb 22, 2023

  • Changes for dependencies and parent pom:
    • set java version as 17 and move maven compiler version to parent
    • remove redundant jackson-core depenency - since it's transitive to jackson-databind
    • remove src from parent - parent is declaration not implementation
  • Take advantage of lombok (yes it was in dependencies but not used 😄 ):
    • log
    • dependency injection with @requiredargsconstructor (btw some dependent components were even not final but injected with constructor)
  • Other refactoring and fixes:
    • Move event source to try with resources to close it after defined timeout
    • Replace topic configuration with default topic
    • Move source stream uri to configuration
    • fix properties file - wrong separator of key/value was used - it's not a .yml 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant