Refactor licensing #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * refactored interfaces * lint * added natspec --------- Co-authored-by: Raul <[email protected]>
* wip * refactored interfaces * lint * wip * moar refactor --------- Co-authored-by: Raul <[email protected]>
* wip * refactored interfaces * lint * wip * moar refactor * refactor natspec to triple slash * lint --------- Co-authored-by: Raul <[email protected]>
* refactoring param names * more underscores --------- Co-authored-by: Raul <[email protected]>
Adds modular refactoring of errors and structs
* Reorder functions by follow official solidity style guide
Summary:
Functions are grouped according to their visibility and ordered:
constructor
receive function (if exists)
fallback function (if exists)
external
public
internal
private
Within a grouping, place the view and pure functions last.
Co-authored-by: Raul <[email protected]>
* using secret store mainnet rpc url * test env var is set * more test env var * add env var to step level * try pull_request_target * trigger test
* Refactors to support global IP asset identification * Removes console logs * Finalizes initial refactor * Fixes import ordering
* decouple IPOrg * move tests into module folders * filter out module tests for now --------- Co-authored-by: Raul <[email protected]>
Authored-by: Raul <[email protected]>
* add base module and IModule * added hook registry * added hook errors * tests and hook registry fixes * fix tests hook registry * lint * add configure to module (#135) Co-authored-by: Raul <[email protected]> * address comments and add execution of hooks * comment gas difference and code coverage for now --------- Co-authored-by: Raul <[email protected]>
* print log of mainnet rpc url * avoid print secrets in log * donot log rpc url * using pull_request event * trigger test * remove public rpc * revert change
* Adds core authorization and attribution to the GIPR * Fixes accidental old code merge * Fixes IPAssetOrg Test
…le (#160) * story protocol entrypoint * remove event emitter * refactor IPOrg * fix * register ipOrg * wip * module registry basic functionality * remove leftover test * module registry routing to modules * add module registyr to SPG * relationship registry * connected SPG with protocol module * config types * test remove relationship * relationship setting * comments and fixes * unify module registry events * refactor selfParams into moduleParams * view methods in IPAssetRegistry --------- Co-authored-by: Raul <[email protected]>
Authored-by: Raul <[email protected]>
…s Base Hooks (#161) * Implementation of Hooks Architecture with Async and Sync Base Hooks
* Add TokenGatedHook Contract for NFT Ownership Verification
* Refactor HookRegistry to support multiple config domain Introduce `registryKey` to separate different config domains. And Integrating BaseModule and Hooks
* list all files in workspace * upgrade openzepplin to 4.9.3
* Refactors IP Org * Adds scaffolding for metadata rendering and ip asset creation * Modularizes IP Org transfers and adds metadata wrapping * Adds IPOrg registration * Fixes stack too deep * Adds back hookregistrykey * Fixes testing * Finalizes registration module (adds necessary FEs needed for SPG integration) * Fix transfer bug
Ramarti
force-pushed
the
refactor_licensing
branch
from
840ac6c to
ad38277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asd