Skip to content

Commit

Permalink
remove leftover test
Browse files Browse the repository at this point in the history
  • Loading branch information
Raul committed Nov 3, 2023
1 parent fcdb8fa commit 18365db
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion contracts/StoryProtocol.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ contract StoryProtocol {
FACTORY = ipOrgFactory_;
}

function registerIpOrg(IPOrgParams.RegisterIpOrgParams calldata params) external returns (address) {
function registerIpOrg(IPOrgParams.RegisterIPOrgParams calldata params) external returns (address) {
return FACTORY.registerIpOrg(params);
}

Expand Down
2 changes: 1 addition & 1 deletion contracts/interfaces/ip-org/IIPOrgFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface IIPOrgFactory is IVersioned {
string tokenURI_
);

function registerIpOrg(IPOrgParams.registerIpOrgParams calldata params_) external returns(address);
function registerIpOrg(IPOrgParams.RegisterIPOrgParams calldata params_) external returns(address);

function isIpOrg(address ipAssetOrg_) external view returns (bool);
}
2 changes: 1 addition & 1 deletion contracts/ip-org/IPOrgFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ contract IPOrgFactory is
/// TODO: Add ipAssetOrg-wide module configurations to the registration process.
/// TODO: Converge on access control for this method
function registerIpOrg(
IPOrgParams.registerIpOrgParams calldata params_
IPOrgParams.RegisterIPOrgParams calldata params_
) public onlyRole(AccessControl.IPORG_CREATOR_ROLE) returns (address) {
address ipAssetOrg = Clones.clone(IP_ORG_IMPL);
IPOrg(ipAssetOrg).initialize(IPOrgParams.InitIPOrgParams({
Expand Down
8 changes: 1 addition & 7 deletions test/foundry/IPOrgTest.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ contract IPOrgTest is Test, ProxyHelper, AccessControlHelper {
}

function test_ipOrgFactory_registerIpOrg() public {
IPOrgParams.RegisterIpOrgParams memory ipOrgParams = IPOrgParams.RegisterIpOrgParams(
IPOrgParams.RegisterIPOrgParams memory ipOrgParams = IPOrgParams.RegisterIPOrgParams(
address(registry),
"name",
"symbol",
Expand All @@ -59,10 +59,4 @@ contract IPOrgTest is Test, ProxyHelper, AccessControlHelper {
ipOrg = IPOrg(ipOrgFactory.registerIpOrg(ipOrgParams));
}

function test_setUp() public {
assertEq(ipOrg.name(), "name");
assertEq(ipOrg.symbol(), "symbol");
assertEq(ipOrg.version(), "0.1.0");
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ contract ProtocolRelationshipModuleSetupRelationshipsTest is BaseTest {
super.setUp();

vm.startPrank(ipAssetOrgOwner);
IPOrgParams.RegisterIpOrgParams memory params = IPOrgParams.RegisterIpOrgParams(
IPOrgParams.RegisterIPOrgParams memory params = IPOrgParams.RegisterIPOrgParams(
address(registry),
"name",
"symbol",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
// // TODO(ramarti): Fix this test
// // function test_revert_relationshipsNotSameIPOrg() public {
// // vm.startPrank(ipAssetOrgOwner);
// // IPAsset.RegisterIpOrgParams memory params = IPAsset.RegisterIpOrgParams(address(registry), "name2", "symbol2", "description2", "tokenURI2", address(licensingModule), address(collectModule));
// // IPAsset.RegisterIPOrgParams memory params = IPAsset.RegisterIPOrgParams(address(registry), "name2", "symbol2", "description2", "tokenURI2", address(licensingModule), address(collectModule));
// // address otherIpAssets = ipAssetOrgFactory.registerIpOrg(params);
// // licensingModule.configureIpOrgLicensing(otherIpAssets, LibMockIPOrgConfig.getMockIPOrgConfig());
// // vm.stopPrank();
Expand Down
2 changes: 1 addition & 1 deletion test/foundry/utils/BaseTest.sol
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ contract BaseTest is BaseTestUtils, ProxyHelper, AccessControlHelper {
defaultCollectNftImpl = _deployCollectNFTImpl();
collectModule = ICollectModule(_deployCollectModule(defaultCollectNftImpl));

IPOrgParams.RegisterIpOrgParams memory ipAssetOrgParams = IPOrgParams.RegisterIpOrgParams(
IPOrgParams.RegisterIPOrgParams memory ipAssetOrgParams = IPOrgParams.RegisterIPOrgParams(
address(registry),
"IPOrgName",
"FRN",
Expand Down

0 comments on commit 18365db

Please sign in to comment.