Fix issues with Windows package workflow #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update to the shaderc-sys crate from 0.7 to 0.8 added a requirement to be able to view the vk.xml file to gather information about the installed version of Vulkan. To fix the workflow, we need to include that file in the list of files being extracted. In addition, the cache action was upgraded from v2 to v4 because the old one was broken with errors like the following: C:/VulkanSDK/1.3.231.1/: Can't create '\\\\?\\C:\\VulkanSDK\\1.3.231.1'
|
Since the Windows package workflow doesn't run by default on PRs, there's not a good way to test this fix here until it is merged. However, I have tested it myself, and the results will be temporarily available at https://github.com/patowen/hypermine/actions. |
Ralith
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to the shaderc-sys crate from 0.7 to 0.8 added a requirement to be able to view the vk.xml file to gather information about the installed version of Vulkan. To fix the workflow, we need to include that file in the list of files being extracted.
In addition, the cache action was upgraded from v2 to v4 because the old one was broken with errors like the following: