Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make saves configurable for the client #384

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

patowen
Copy link
Collaborator

@patowen patowen commented Apr 27, 2024

Having the ability to choose which save file is active would allow me to swap between them when, for instance, trying out different chunk sizes or switching between an older and newer version of Hypermine. It would also make it easier to test save files on an HDD to make sure that doesn't become an important bottleneck.

Fortunately, it looks like the implementation for this is quite simple. I chose to call the configuration option save for consistency with the server. If you give it a full path, it will save at that path, but if you give it a partial path, it will save in the data directory. All of this functionality comes for free with the PathBuf::join function.

@Ralith Ralith enabled auto-merge (rebase) April 27, 2024 02:44
@Ralith Ralith merged commit 8f0732a into Ralith:master Apr 27, 2024
6 checks passed
@patowen patowen deleted the configurable-saves branch April 27, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants