Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed NUnit LifeCycle from "InstancePerTestCase" to "SingleInstance" #1038

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

changed NUnit LifeCycle from "InstancePerTestCase" to "SingleInstance" #1038

wants to merge 2 commits into from

Conversation

RalfKoban
Copy link
Owner

No description provided.

@RalfKoban RalfKoban changed the title changed NUNit LifeCycle from "InstancePerTestCase" to "SingleInstance" changed NUnit LifeCycle from "InstancePerTestCase" to "SingleInstance" Sep 20, 2024
Repository owner deleted a comment from CodiumAI-Agent Sep 20, 2024
@RalfKoban
Copy link
Owner Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Configuration Change
The change from LifeCycle.InstancePerTestCase to LifeCycle.SingleInstance could significantly affect test isolation and performance. This change means that the same instance of the test class will be used for all tests in the class, which can lead to shared state issues if not handled carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feasability unclear
Projects
MiKo Analyzers
Status: On hold
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfKoban @CodiumAI-Agent