Changed call to confirm! to a call to confirm in recipes/init.rb to fix the Devise confirmable module #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. @DanielKehoe do you think we can merge this? This has affected every app I have generated for at least 10 months and would be a welcome addition! |
|
@tomelam Thanks for fixing this! I've released an updated version of the rails_apps_composer gem. @kevinelliott thanks for reminding me. I'm sorry for the slow response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue RailsApps/rails-devise-roles#11 ("create_admin_service.rb causes rake to fail because the confirm! method was removed from the Devise gem").
Please refer to the changelog in master of the Devise gem.