Refactored attiny_hal for additive features
#605
+1,073
−784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
from
05a3c0f to
e0e975d
Compare
This was referenced Nov 24, 2024
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
6 times, most recently
from
5f261ea to
4ffe0b8
Compare
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
from
4ffe0b8 to
674f0ed
Compare
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
2 times, most recently
from
c5a9717 to
42bd207
Compare
|
The issue is a bit old at this point, but perhaps this restructure could be an item in #130 under "Redesign HAL APIs/internals for more flexibility towards supported devices". |
|
@tones111 Thanks for pointing that out! Yes, this work is very much aligned with that refactor. (There are many other desired / planned improvements that are being tracked by #130, and I am not trying to address those here; specifically, I am not introducing any API changes here, I am just restructuring modules and macros, which I think has organizational value in its own right.) |
|
On Wed, Jan 01, 2025 at 04:28:01AM -0800, Iris Artin wrote:
Thanks for pointing that out!
Yes, this work is very much aligned with that refactor.
This issue now has a reference to #623.
|
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
from
42bd207 to
fc3ee61
Compare
innermatrix
force-pushed
the
attiny-hal-additive-features
branch
from
fc3ee61 to
6515962
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #602 for context and overall plan. This PR refactors
attiny_halto make conflicting globals optional (but available by default).Changes:
deprecated-globalsfeature (on by default)<mcu>-no-deprecated-globalsfeatures for all MCU, which can be used to build the crate for multiple MCUs