Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code for the atmega8u2 HAL #159

Closed
wants to merge 1 commit into from
Closed

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Mar 8, 2021

I haven't done much testing on this yet; we need to merge the changes to avr-device in first.

@Rahix
Copy link
Owner

Rahix commented Mar 8, 2021

Ah, sorry, I didn't make it clear enough I guess :( We're currently in the process of reworking almost the entirety of avr-hal. See issue #130 for details. This work is happening in the next branch in this repository and I would suggest that you add the new chip ontop that branch because anything on master won't be here to stay for that much longer. I.e. you'll have to open a PR against the next branch and do changes similar to other PRs which were part of the refactoring. Most are linked in issue #130, but as a good examples, take a look at #145 which adds support for ATmega168.

Sorry for not explaining that better from the get go :/

@drmorr0
Copy link
Contributor Author

drmorr0 commented Mar 9, 2021

@Rahix no worries! This wasn't too hard to put together, I just wanted some validation that the avr-device change was correct. I'll work on getting this into the next branch now :)

@drmorr0 drmorr0 closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants