Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkov scanning, force IMDSv2, update resources to pass scans #16

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

rtkmhart
Copy link
Contributor

@rtkmhart rtkmhart commented Feb 1, 2024

This PR adds checkov security scanning to the workflow, and update resources to pass the scans. Two resources change, with in-place updates:

  • SSM parameter, change from String to SecureString
  • enforce IMDSv2 on the NAT instances, which the code is already using (source)

There are two skipped checks:

  • NAT instances have a public IP on purpose
  • Launch template has an IAM instance profile attached, but checkov can't follow that logic

@RaJiska
Copy link
Owner

RaJiska commented Feb 25, 2024

Thanks for the PR @rtkmhart, great addition. LGTM.

@RaJiska RaJiska merged commit 79983a3 into RaJiska:main Feb 25, 2024
1 check passed
@lyuboraykov
Copy link

@rtkmhart thanks for implementing this! @RaJiska are you planning on making a release with the latest changes soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants