Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1561 airflowwindowventilationempiricalexpressionsdin16798 add deactivation option for window opening #1564

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jun-Jiang-92
Copy link
Contributor

Add parameter "winOpnBeh" to the model of DIN EN 16798-7.

This parameter should be set to false, if the window opening behavior of occupant is not considered for the calculation of airflow rate. In this case, the correction factor cofExt will be set as 1. If this parameter is activated, the airflow rate will be reduced by the correction factor cofExt by high wind speed or low ambient temperature, caused by the window closing from occupant due to draught and thermal comfort.

Both examples are also updated for comparisons.

Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
@Jun-Jiang-92
Copy link
Contributor Author

@FWuellhorst Hi, Fabian. I updated one paramter for the model of DIN EN 16798-7 for the package window ventilation. Since you reviewed the entire package last time and you are familiar with this package, could you please take a review of this PR?

@ebc-aixlib-bot
Copy link
Contributor

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/1561-airflowwindowventilationempiricalexpressionsdin16798-add-deactivation-option-for-window-opening/charts

…ion reference files. Please pull the new files before push again. Plottet Results /1561-airflowwindowventilationempiricalexpressionsdin16798-add-deactivation-option-for-window-opening/charts/
@ebc-aixlib-bot
Copy link
Contributor

Thank you for making a Pull Request to AixLib!

Our CI pipeline will help you finalize your contribution.
Here's what is typically checked:

  • HTML syntax of your models, primarily in your documentation.
  • Adherence to the naming convention in all changed files.
  • Ability to check all models.
  • Ability to simulate all models, if they are examples.
  • If your contribution changes existing reference results.

If HTML errors occur, I will fix the issues using a separate pull request.
For the other checks, I will post the results here: https://rwth-ebc.github.io/AixLib/1561-airflowwindowventilationempiricalexpressionsdin16798-add-deactivation-option-for-window-opening/index.html

Tips to fix possible naming violations:

  • Stick to the naming guidelines, e.g. Namespace Requirements
  • Do all paramaters, variables, models, etc. have a description?
  • Use absolute paths to classes! -> AixLib.Fluid.HeatExchangers.Radiator - Avoid: HeatExchangers.Radiator

If all CI stages pass and you have addressed possible naming violations, please consider the following:

  • Use "group" and "tab" annotations to achieve a good visualization window.
  • Use units consistently.
  • Instantiate the replaceable medium package as:
    replaceable package Medium = Modelica.Media.Interfaces.PartialMedium "Medium model";
    instead of using a full media model like AixLib.Media.Water directly.
  • Never using absolute paths to files (e.g., C: or D:). Replace them with modelica://AixLib/....
  • Ensure your documentation is helpful and concise.
  • Make sure icons are clear. Please avoid using images!
  • Stick to 80 characters per line, as long as it makes sense.
  • Add or modify examples for new or revised models.
  • Include a simulate-and-plot script as a regression test for new models.
    How? Follow the documentation here: https://github.com/ibpsa/modelica-ibpsa/wiki/Unit-Tests#how-to-include-models-as-part-of-the-unit-tests
    Tip: To create the initial script, you can use Dymolas script generator, explained here: https://www.claytex.com/tech-blog/how-to-use-a-plot-script/)

Once you have addressed these points, you can assign a reviewer.
Although this process may seem tedious, ensuring CI passes allows the reviewer to focus
their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer.
Once again, thank you for your valuable contribution!

Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have minor comments, please address/comment merge afterwards.

Comment on lines -40 to 28
0.0357*openingArea.A*(winSpeLoc - winSpeLim) else 0;
// If winSpeLoc < winSpeLim, wind-driven airflow negligible
V_flow_win = 0.0357*openingArea.A*max(winSpeLoc - winSpeLim, 0);
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a revision why this changed?

AixLib.Airflow.WindowVentilation.OpeningAreas.OpeningAreaSashDIN16798 (
opnTyp=AixLib.Airflow.WindowVentilation.BaseClasses.Types.WindowOpeningTypes.BottomHungInward),
heightASL=200,
winOpnBeh=true) "Model DIN 16798, with window opening behavior"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advise setting winOpnBeh final in both models with and without opening behavior to avoid users overriding it. If you know use cases where a non-final setting is useful, keep it this way.

redeclare model OpeningArea =
AixLib.Airflow.WindowVentilation.OpeningAreas.OpeningAreaSimple,
heightASL=200,
winOpnBeh=true) "Model DIN 16798, with window opening behavior"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. Also, explicitly set winOpnBeh in any case to avoid changes if someone changes the default at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow.WindowVentilation.EmpiricalExpressions.DIN16798: Add deactivation option for window opening
3 participants