-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1561 airflowwindowventilationempiricalexpressionsdin16798 add deactivation option for window opening #1564
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
@FWuellhorst Hi, Fabian. I updated one paramter for the model of DIN EN 16798-7 for the package window ventilation. Since you reviewed the entire package last time and you are familiar with this package, could you please take a review of this PR? |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/1561-airflowwindowventilationempiricalexpressionsdin16798-add-deactivation-option-for-window-opening/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /1561-airflowwindowventilationempiricalexpressionsdin16798-add-deactivation-option-for-window-opening/charts/
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Signed-off-by: Jun Jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have minor comments, please address/comment merge afterwards.
0.0357*openingArea.A*(winSpeLoc - winSpeLim) else 0; | ||
// If winSpeLoc < winSpeLim, wind-driven airflow negligible | ||
V_flow_win = 0.0357*openingArea.A*max(winSpeLoc - winSpeLim, 0); | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a revision why this changed?
AixLib.Airflow.WindowVentilation.OpeningAreas.OpeningAreaSashDIN16798 ( | ||
opnTyp=AixLib.Airflow.WindowVentilation.BaseClasses.Types.WindowOpeningTypes.BottomHungInward), | ||
heightASL=200, | ||
winOpnBeh=true) "Model DIN 16798, with window opening behavior" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would advise setting winOpnBeh final in both models with and without opening behavior to avoid users overriding it. If you know use cases where a non-final setting is useful, keep it this way.
redeclare model OpeningArea = | ||
AixLib.Airflow.WindowVentilation.OpeningAreas.OpeningAreaSimple, | ||
heightASL=200, | ||
winOpnBeh=true) "Model DIN 16798, with window opening behavior" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. Also, explicitly set winOpnBeh in any case to avoid changes if someone changes the default at some point.
Add parameter "winOpnBeh" to the model of DIN EN 16798-7.
This parameter should be set to
false
, if the window opening behavior of occupant is not considered for the calculation of airflow rate. In this case, the correction factorcofExt
will be set as1
. If this parameter is activated, the airflow rate will be reduced by the correction factorcofExt
by high wind speed or low ambient temperature, caused by the window closing from occupant due to draught and thermal comfort.Both examples are also updated for comparisons.