-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1451 add pvt model #1458
base: main
Are you sure you want to change the base?
Issue1451 add pvt model #1458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition to the AixLib.
The equation look correct, but there are some style-guide issues which need to be addressed. If you have questions, just comment below. Most of them were already wrong in the SolarThermal model, but we agreed on fixing those issues if we adapt existing models.
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/ElectricalGlazedPVTWithoutLowEmissionCoating.mo
Outdated
Show resolved
Hide resolved
AixLib/DataBase/PhotovoltaicThermal/PhotovoltaicThermalBaseDataDefinitionElectrical.mo
Outdated
Show resolved
Hide resolved
…-model Corrected HTML Code in branch correct_HTML_issue1451-add-pvt-model
…/AixLib into issue1451-add-pvt-model
…-model Corrected HTML Code in branch correct_HTML_issue1451-add-pvt-model
…hange example for colder day
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts |
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /issue1451-add-pvt-model/charts/
…/AixLib into issue1451-add-pvt-model
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thank you for the pvt model!
AixLib/Fluid/SolarCollectors/PhotovoltaicThermal/Data/PhotovoltaicThermalBaseDataDefinition.mo
Outdated
Show resolved
Hide resolved
AixLib/Fluid/SolarCollectors/PhotovoltaicThermal/Data/PhotovoltaicThermalBaseDataDefinition.mo
Outdated
Show resolved
Hide resolved
AixLib/Fluid/SolarCollectors/PhotovoltaicThermal/Data/Unglazed.mo
Outdated
Show resolved
Hide resolved
a2=perPVT.a2)); | ||
replaceable parameter AixLib.Fluid.SolarCollectors.PhotovoltaicThermal.Data.PhotovoltaicThermalBaseDataDefinition perPVT | ||
constrainedby AixLib.Fluid.SolarCollectors.PhotovoltaicThermal.Data.PhotovoltaicThermalBaseDataDefinition | ||
"Performance data for PV-Thermal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change the description in the EN12975 model from "performance data" to something like "performance data for Solar Thermal Collector". This could be helpful to understand that per is only for the thermal part and perPVT is both, thermal and electric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used "Performance data for both solar thermal collector and PV"
, is this better?
added a simple photovoltaic thermal collector based on the already existing solar thermal model