Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1451 add pvt model #1458

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Issue1451 add pvt model #1458

wants to merge 29 commits into from

Conversation

Philipp-Schmitz
Copy link

added a simple photovoltaic thermal collector based on the already existing solar thermal model

@Philipp-Schmitz Philipp-Schmitz linked an issue Aug 24, 2023 that may be closed by this pull request
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition to the AixLib.

The equation look correct, but there are some style-guide issues which need to be addressed. If you have questions, just comment below. Most of them were already wrong in the SolarThermal model, but we agreed on fixing those issues if we adapt existing models.

@ebc-aixlib-bot
Copy link
Contributor

Thank you for making a Pull Request to AixLib!

Our CI pipeline will help you finalize your contribution.
Here's what is typically checked:

  • HTML syntax of your models, primarily in your documentation.
  • Adherence to the naming convention in all changed files.
  • Ability to check all models.
  • Ability to simulate all models, if they are examples.
  • If your contribution changes existing reference results.

If HTML errors occur, I will fix the issues using a separate pull request.
For the other checks, I will post the results here: https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/index.html

Tips to fix possible naming violations:

  • Stick to the naming guidelines, e.g. Namespace Requirements
  • Do all paramaters, variables, models, etc. have a description?
  • Use absolute paths to classes! -> AixLib.Fluid.HeatExchangers.Radiator - Avoid: HeatExchangers.Radiator

If all CI stages pass and you have addressed possible naming violations, please consider the following:

  • Use "group" and "tab" annotations to achieve a good visualization window.
  • Use units consistently.
  • Instantiate the replaceable medium package as:
    replaceable package Medium = Modelica.Media.Interfaces.PartialMedium "Medium model";
    instead of using a full media model like AixLib.Media.Water directly.
  • Never using absolute paths to files (e.g., C: or D:). Replace them with modelica://AixLib/....
  • Ensure your documentation is helpful and concise.
  • Make sure icons are clear. Please avoid using images!
  • Stick to 80 characters per line, as long as it makes sense.
  • Add or modify examples for new or revised models.
  • Include a simulate-and-plot script as a regression test for new models.
    How? Follow the documentation here: https://github.com/ibpsa/modelica-ibpsa/wiki/Unit-Tests#how-to-include-models-as-part-of-the-unit-tests
    Tip: To create the initial script, you can use Dymolas script generator, explained here: https://www.claytex.com/tech-blog/how-to-use-a-plot-script/)

Once you have addressed these points, you can assign a reviewer.
Although this process may seem tedious, ensuring CI passes allows the reviewer to focus
their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer.
Once again, thank you for your valuable contribution!

@ebc-aixlib-bot
Copy link
Contributor

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts

@ebc-aixlib-bot
Copy link
Contributor

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts

…ion reference files. Please pull the new files before push again. Plottet Results /issue1451-add-pvt-model/charts/
@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts

@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/issue1451-add-pvt-model/charts

Copy link
Contributor

@TobiasSpratte TobiasSpratte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thank you for the pvt model!

a2=perPVT.a2));
replaceable parameter AixLib.Fluid.SolarCollectors.PhotovoltaicThermal.Data.PhotovoltaicThermalBaseDataDefinition perPVT
constrainedby AixLib.Fluid.SolarCollectors.PhotovoltaicThermal.Data.PhotovoltaicThermalBaseDataDefinition
"Performance data for PV-Thermal"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change the description in the EN12975 model from "performance data" to something like "performance data for Solar Thermal Collector". This could be helpful to understand that per is only for the thermal part and perPVT is both, thermal and electric.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used "Performance data for both solar thermal collector and PV", is this better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PVT model
5 participants