Use constinit in logs.cpp #16287
Open
Use constinit in logs.cpp #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if it will compile yet.
|
you could probably do something like this for now?
|
|
Or put the decleration out of the function |
I don't think it matters, it's some compiler support problem that blocks constexpr default constructor (should be in c++20) |
|
My suggestion compiles on msvc at least (no idea if it's better than the current code) |
Use unique_ptr wrapper
Fix std::string reuse
Megamouse
reviewed
Nov 5, 2024
rpcs3/util/logs.cpp
Outdated
| if (!args_) | ||
| args_ = std::make_unique<std::vector<u64>>(); | ||
| auto& text = *text_.get(); | ||
| auto& args = *args_.get(); |
There was a problem hiding this comment.
I don't think .get is needed?
|
Damn MSVC what the hell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it will compile yet.