Merging PR#327 into main branch #328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer #327 for more info
|
We can't allow hard coding an arbitrary list of architectures here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #327 for more info
We need this PR to fix the issue as coming in http://rocm-ci.amd.com/view/Release-6.3/job/framework-vllm-2.4-ub22-py3.10-ci-rel-6.3/61/console
16:45:11 #27 54.52 CMake Error at CMakeLists.txt:186 (message):
16:45:11 #27 54.52 Target architectures support different types of FP8 formats!
Ticket : https://ontrack-internal.amd.com/browse/SWDEV-503927