Code enhancements #1429
Open
Code enhancements #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to MEM_LEAK_FIXES Syncing remote changes
Mem leak fixes
Deleting temporary scripts I created for debugging and testing
Mem leak test tools
PJAvinash
requested review from
wenkaidu,
gilbertlee-amd,
akolliasAMD,
edgargabriel,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd,
mustafabar,
thananon and
haripriya-amd
as code owners
wenkaidu
reviewed
Jan 3, 2025
| @@ -505,9 +510,6 @@ ncclResult_t ncclIbInit(ncclDebugLogger_t logFunction) { | |||
| ncclIbMergedDevs[mergedDev].speed += ncclIbDevs[ncclNIbDevs].speed; | |||
| ncclNIbDevs++; | |||
| nPorts++; | |||
| // [RCCL] | |||
| pthread_detach(ncclIbAsyncThread); | |||
| // [/RCCL] | |||
There was a problem hiding this comment.
Why removing pthread_detach? This was added to fix a memory leak issue.
There was a problem hiding this comment.
pthread_detach() is being called twice with same parameter, first time at line 486, second call will simply return -1 and it is not being checked, and has no effect.
wenkaidu
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Enhancing code
Work item: "Internal"
What were the changes?
Modifying / enhancing failure path in ncclIBInit()
Why were the changes made?
Code improvements
How was the outcome achieved?
Analyzing the code with debugger
Additional Documentation:
pthread_detach() call is removed as it is a side effect of earlier nccl sync
Approval Checklist
Do not approve until these items are satisfied.