[flang][OpenMP] Support host_eval for target teams loop
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends `host_eval` support for the currently supported form of the generic `loop` directive.
skatrak
reviewed
Dec 11, 2024
Comment on lines
+575
to
+579
| case OMPD_loop: | ||
| case OMPD_teams_loop: | ||
| case OMPD_target_teams_loop: | ||
| cp.processCollapse(loc, eval, hostInfo.ops, hostInfo.iv); | ||
| break; |
There was a problem hiding this comment.
Here we need to also make sure thread_limit and num_teams are processed when applicable.
Suggested change
| case OMPD_loop: | |
| case OMPD_teams_loop: | |
| case OMPD_target_teams_loop: | |
| cp.processCollapse(loc, eval, hostInfo.ops, hostInfo.iv); | |
| break; | |
| case OMPD_teams_loop: | |
| cp.processThreadLimit(stmtCtx, hostInfo.ops); | |
| [[fallthrough]]; | |
| case OMPD_target_teams_loop: | |
| cp.processNumTeams(stmtCtx, hostInfo.ops); | |
| [[fallthrough]]; | |
| case OMPD_loop: | |
| cp.processCollapse(loc, eval, hostInfo.ops, hostInfo.iv); | |
| break; |
| @@ -1909,7 +1909,7 @@ llvm::omp::OMPTgtExecModeFlags TargetOp::getKernelExecFlags() { | |||
|
|
|||
| // Detect Generic-SPMD: target-teams-distribute[-simd]. | |||
| if (numWrappers == 1) { | |||
| if (!isa<DistributeOp>(innermostWrapper)) | |||
| if (!isa<DistributeOp>(innermostWrapper) && !isa<LoopOp>(innermostWrapper)) | |||
There was a problem hiding this comment.
This is slightly incorrect, because it will cause target teams loop to be tagged as Generic-SPMD instead of SPMD. Perhaps you can set a local llvm::omp::OMPTgtExecModeFlags variable to OMP_TGT_EXEC_MODE_GENERIC_SPMD or OMP_TGT_EXEC_MODE_SPMD based on whether the wrapper is omp.distribute or omp.loop and return it if all conditions below are met, instead of it always being OMP_TGT_EXEC_MODE_GENERIC_SPMD.
Also update the comment above, to prevent it from becoming misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
host_evalsupport for the currently supported form of the genericloopdirective.