Enable fwd and varlen_fwd on AMD #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micmelesse
changed the title
Compress This is a combination of 12 commits. add scripts save add our kernel import our kernel round trip use bshd layout figure out segfault fix show backward failure with prints save backward work run forward only test smallest config on everything add test fix remove pre commit install triton skip dropout pin d 32 factor d just run power of 2 remove timeout run serially clean up clean up 2
micmelesse
force-pushed
the
micmelesse/enable_fwd
branch
from
74654c7 to
2e2cc43
Compare
This is a combination of 6 commits. save some tests passing enable more enable everything move around alibi works
micmelesse
changed the title
vgokhale
reviewed
Jun 13, 2024
vgokhale
reviewed
Jun 13, 2024
|
@vgokhale Can I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable flash_attn_func using amd's triton flash attention kernel.
This enables
flash_attn_func. There will be follow up prs to enable the forward pass of the other flash attention apis.we skip building the cuda kernels and use the triton kernel on AMD. This is fine for our fork but upstream will probably require a way to have one wheel.