Skip to content

Commit

Permalink
Address Feedback
Browse files Browse the repository at this point in the history
This is a combination of 4 commits.

final clean

clean up

address feedback

clean up
  • Loading branch information
micmelesse committed Oct 14, 2024
1 parent 75b5360 commit c119315
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 77 deletions.
68 changes: 0 additions & 68 deletions .github/workflows/amd_tests.yml

This file was deleted.

4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ var/
*.egg-info/
.installed.cfg
*.egg
.eggs

# IDE-related
.idea/

# Dev
venv
scripts
venv
13 changes: 7 additions & 6 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ def validate_and_update_archs(archs):
# We want this even if SKIP_CUDA_BUILD because when we run python setup.py sdist we want the .hpp
# files included in the source distribution, in case the user compiles from source.
if IS_ROCM:
subprocess.run(["git", "submodule", "update", "--init", "csrc/composable_kernel"])
if not USE_TRITON_ROCM:
subprocess.run(["git", "submodule", "update", "--init", "csrc/composable_kernel"])
else:
subprocess.run(["git", "submodule", "update", "--init", "csrc/cutlass"])

Expand Down Expand Up @@ -300,15 +301,10 @@ def validate_and_update_archs(archs):
)
)
elif not SKIP_CUDA_BUILD and IS_ROCM:
ck_dir = "csrc/composable_kernel"

#use codegen get code dispatch
if not os.path.exists("./build"):
os.makedirs("build")

os.system(f"{sys.executable} {ck_dir}/example/ck_tile/01_fmha/generate.py -d fwd --output_dir build --receipt 2")
os.system(f"{sys.executable} {ck_dir}/example/ck_tile/01_fmha/generate.py -d bwd --output_dir build --receipt 2")

print("\n\ntorch.__version__ = {}\n\n".format(torch.__version__))
TORCH_MAJOR = int(torch.__version__.split(".")[0])
TORCH_MINOR = int(torch.__version__.split(".")[1])
Expand All @@ -317,6 +313,11 @@ def validate_and_update_archs(archs):
# Skip C++ extension compilation if using Triton Backend
pass
else:
ck_dir = "csrc/composable_kernel"

os.system(f"{sys.executable} {ck_dir}/example/ck_tile/01_fmha/generate.py -d fwd --output_dir build --receipt 2")
os.system(f"{sys.executable} {ck_dir}/example/ck_tile/01_fmha/generate.py -d bwd --output_dir build --receipt 2")

# Check, if ATen/CUDAGeneratorImpl.h is found, otherwise use ATen/cuda/CUDAGeneratorImpl.h
# See https://github.com/pytorch/pytorch/pull/70650
generator_flag = []
Expand Down

0 comments on commit c119315

Please sign in to comment.