Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CK Tile Gemm API and heuristics changes #1809
base: develop
Are you sure you want to change the base?
CK Tile Gemm API and heuristics changes #1809
Changes from all commits
896f8b4
3cad16c
aa30ef5
c2945b9
d5c5d2a
9032352
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 2025?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add your nick name to todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use
@
syntax instead of\
. Please have a look attile_partitioner
fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[Consider]] Please have a look that we repeatedly use mechanisms to check whether we have a specific layout...
t.is_a_rowmajor && t.is_b_rowmajor && t.is_c_rowmajor
etc.Maybe it would be worth considering
has_enabled_RRR
mechanis *(1), either at the traits structure level or as a separate mechanism? This way, we could avoid duplicating these checks, reduce the possibility of mistakes etc.*(1) Example:
This file was deleted.