Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gains version.md guidance #34

Merged
merged 6 commits into from
Mar 4, 2024
Merged

feat: gains version.md guidance #34

merged 6 commits into from
Mar 4, 2024

Conversation

jdhoffa
Copy link
Collaborator

@jdhoffa jdhoffa commented Mar 4, 2024

This PR documents much of our discussion around "Software Versioning" guidance.

Closes #18

version.md Outdated Show resolved Hide resolved
version.md Show resolved Hide resolved
cjyetman
cjyetman previously approved these changes Mar 4, 2024
AlexAxthelm
AlexAxthelm previously approved these changes Mar 4, 2024
Copy link

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, non-blocking

version.md Outdated Show resolved Hide resolved
version.md Outdated Show resolved Hide resolved
version.md Outdated Show resolved Hide resolved
version.md Outdated Show resolved Hide resolved
version.md Outdated Show resolved Hide resolved
MonikaFu
MonikaFu previously approved these changes Mar 4, 2024
Copy link

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the changes proposed by @AlexAxthelm.

Co-authored-by: Alex Axthelm <[email protected]>
@jdhoffa jdhoffa dismissed stale reviews from MonikaFu, AlexAxthelm, and cjyetman via 2505f99 March 4, 2024 12:33
jacobvjk
jacobvjk previously approved these changes Mar 4, 2024
version.md Outdated Show resolved Hide resolved
Copy link

@MonikaFu MonikaFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdhoffa jdhoffa merged commit 5f9fb7c into main Mar 4, 2024
@jdhoffa jdhoffa deleted the 18-versioning branch March 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define and document our "release" process
5 participants