build(docker): Use core RMI workflow #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a branch workflow to build the docker image now that it supports specifying platforms Closes: #45
Docker build status
History
History JSON`[{"commit_time":"2024-04-30T16:04:07Z","git_sha":"6351eb4ecfed613c19dc6d2eb947659db61a7248","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"},{"commit_time":"2024-04-18T13:12:30Z","git_sha":"0e207f02530f166c47afbb397cba6694c7088517","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"},{"commit_time":"2024-04-17T13:09:12Z","git_sha":"e58ebbc6e6a83ccea1d282fd113eeda2e36cae8e","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"},{"commit_time":"2024-04-17T12:54:16Z","git_sha":"d4d925bff9a2368219e9a44be3499d56be5c41ef","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"},{"commit_time":"2024-04-17T12:27:16Z","git_sha":"b71219d2fdc68ea5c82c687a118838e0c61f35b4","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"},{"commit_time":"2024-04-17T12:21:39Z","git_sha":"e85f891eb7757cced498343136b0f43033982281","image":"ghcr.io/rmi-pacta/workflow.scenario.preparation:pr-47"}]` |
AlexAxthelm
changed the title
|
Depends on RMI-PACTA/actions#77 |
with the dependency PRs merged in RMI-PACTA/actions, we can go back to using main branch
cjyetman
requested changes
Apr 17, 2024
|
The changes to the docker file are relevant to this PR, since they are needed to pass the check system dependencies check. |
|
I'd rather not install specific versions of system software and instead let that be determined by the most up-to-date information for the installed versions of the R packages that depend on them. |
|
This is a discussion we've had before. It's better to have the dependencies be explicit, with known versions, than to have new sysdeps introduced unexpectedly. |
|
I disagree |
|
superseded by #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a branch workflow to build the docker image now that it supports specifying platforms
Closes: #45