-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): #57 Build from recent image #59
Conversation
Build from a recent image from the public registry for `workflow.transition.monitor`. While these images don't include the pacta-data needed to prepare indices, the current README instructions include a requirement to externally mount PACTA-data. Closes: #57
long-term goal: use explicit pinning on SHA for stability
|
maybe should update the README along with this? workflow.prepare.pacta.indices/README.md Lines 15 to 20 in cac36ee
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, please update README
accordingly
verified that this works once #62 is included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see minor spelling suggestions
Co-authored-by: CJ Yetman <[email protected]>
Note, we can't get around the install requirement entirely, since
and we can see that. it's not trying to reinstall any of the other pacta packages. |
Would it be prudent to fail the build if (pacta) dependencies are out of date? |
pacta.data.scraping is fine to install, it's just the packages already in the TM image that we should avoid overwriting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trusting @cjyetman's review and rubber stamping.
I did not review this myself.
Build from a recent image from the public registry for
workflow.transition.monitor
. While these images don't include the pacta-data needed to prepare indices, the current README instructions include a requirement to externally mount PACTA-data.Closes: #57