Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: CJ Yetman <[email protected]>
  • Loading branch information
AlexAxthelm and cjyetman authored Jan 30, 2024
1 parent 6b9efd8 commit e718522
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-push-Docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
echo "full-image-name=$full_image_name" >> "$GITHUB_OUTPUT"
echo "$full_image_name" > full-image-name
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: full-image-name
path: .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-hadolint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
hadolint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: hadolint/[email protected]
with:
dockerfile: Dockerfile
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Description: What the package does (one paragraph).
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
Imports:
digest,
dplyr,
Expand Down
1 change: 1 addition & 0 deletions R/export_portfolio.R
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export_portfolio <- function(
x = portfolio_data,
file = output_filepath,
row.names = FALSE,
na = "",
fileEncoding = "UTF-8"
)
logger::log_debug("Portfolio data written to file: ", output_filepath)
Expand Down

0 comments on commit e718522

Please sign in to comment.