-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile Cleaning #60
Conversation
Docker build status
|
FYI... the audit file is the first thing written, so I suspect something with the output paths is not right with 2022Q4 GENERAL and 2023Q4 GENERAL builds (errors in the latest CI/CD) https://github.com/RMI-PACTA/workflow.pacta/actions/runs/9205271961/job/25320684835?pr=60#step:7:104
|
@cjyetman I think cleaning up some of the bind mounts is probably the next thing on the list for this one, as part of specifying the default/inherited configs. |
This reverts commit c3376be.
Cleaning up the Dockerfile!
The biggest structural change here is in the block that writes
Rprofile.site
. That now uses the builtinTARGETPLATFORM
build arg (more info) to determine if we should be pulling Binaries (for Ubuntu Jammy) or building packages from source (everything else).The other notable change is cleaning up the
LABEL
instructions, which in conjunction with RMI-PACTA/actions#85 provides up to date labels, includingrevision
andversion
.Smaller Changes:
root
as userdocker.io/rocker/r-ver
, rather thanrocker/r-ver
)DEBIAN_FRONTEND
from build args to inline envvaroptions
to control behavior ofpak
andpkgload
/workflow.pacta
instead of system root dir.Closes #55
Closes #46