Skip to content

Commit

Permalink
Handle param validation with array of files
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexAxthelm committed Sep 2, 2024
1 parent b8cb02c commit 604b2b3
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: workflow.pacta
Title: Run PACTA
Version: 0.0.0.9010
Version: 0.0.0.9011
Authors@R:
c(person(given = "CJ",
family = "Yetman",
Expand Down Expand Up @@ -39,7 +39,7 @@ Remotes:
RMI-PACTA/pacta.portfolio.audit,
RMI-PACTA/pacta.portfolio.import,
RMI-PACTA/pacta.portfolio.utils,
RMI-PACTA/pacta.workflow.utils
RMI-PACTA/pacta.workflow.utils@list-as-is
Suggests:
testthat (>= 3.0.0),
withr
Expand Down
8 changes: 6 additions & 2 deletions inst/extdata/schema/portfolio.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@
"type": "object",
"properties": {
"files": {
"type": "string",
"description": "List of portfolio files to be analyzed."
"type": "array",
"description": "List of portfolio files to be analyzed.",
"items": {
"type": "string",
"description": "Path to the file."
}
},
"holdingsDate": {
"type": "string",
Expand Down
4 changes: 3 additions & 1 deletion tests/config/full_params_2022Q4.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"parameters": {
"portfolio": {
"holdingsDate": "2022-12-31",
"files": "default_portfolio.csv",
"files": [
"default_portfolio.csv"
],
"name": "Default Portfolio"
},
"analysis": {
Expand Down

0 comments on commit 604b2b3

Please sign in to comment.