ensure the AI Company ID to Entity ID data has only distinct rows #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhoffa
reviewed
Feb 9, 2024
Comment on lines
+246
to
+247
| ) %>% | ||
| distinct() |
There was a problem hiding this comment.
NIT: Should this be something we warn about? like "X input contains duplicate rows, removing"
Maybe not important.
There was a problem hiding this comment.
🤷 maybe? I think that it should be expected that all of these inputs do not have random duplicate lines.
I've already gone down the rabbit hole of imagining adding validation functions to pacta.data.preparation for all of these inputs and all of the configuration options 😈
There was a problem hiding this comment.
yeah i mean, in my perfect world, once #94 is closed, I would imagine just adding a simple "warning" message in the wrapper function whenever this kind of wonkiness happens would be sufficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101