-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider refactoring components with strict methodological significance to pacta.data.preparation
or pacta.scenario.preparation
#94
Comments
cc: @AlexAxthelm and @cjyetman this would get us closer to having "all methodology" in |
depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/333 works toward #94 - replaces explicit code in [run_pacta_data_preparation.R](https://github.com/RMI-PACTA/workflow.data.preparation/edit/main/run_pacta_data_preparation.R) with the function `pacta.data.preparation::determine_relevant_years()` which wraps all the necessary methodological logic and does robust input checking
note that any of the code here referencing |
…` functions (#195) - [x] depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/353 - work towards #94 Co-authored-by: CJ Yetman - RMI <[email protected]>
- towards #94 - depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/359 Co-authored-by: CJ Yetman - RMI <[email protected]>
- towards #94 - depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/357 --------- Co-authored-by: CJ Yetman - RMI <[email protected]>
- towards #94 - depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/360 --------- Co-authored-by: CJ Yetman - RMI <[email protected]>
- towards #94 - depends on https://github.com/RMI-PACTA/pacta.data.preparation/pull/361 --------- Co-authored-by: CJ Yetman - RMI <[email protected]>
all but the scenario stuff has been implemented, closing |
PROBABLY DON'T DO THIS PRIOR TO SUCCESSFUL DELIVERY OF PACTA COP CH 2024
Towards a world where
workflow
s handle file I/O and configuration and DevOps mainlyand
pacta.*
handles as much methodology as possible. Relates to RMI/practices#2maybe refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/357 and usepacta.data.preparation::determine_relevant_years()
#208)workflow.data.preparation/run_pacta_data_preparation.R
Lines 94 to 98 in 5801f95
refactor to
pacta.scenario.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/358 and usenot going to do this until after a switch to pacta.scenario.data.preparation is madepacta.data.preparation::prepare_scenarios_long()
#209)workflow.data.preparation/run_pacta_data_preparation.R
Lines 131 to 146 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/359 and usepacta.data.preparation::standardize_asset_type_names()
#210)workflow.data.preparation/run_pacta_data_preparation.R
Lines 175 to 186 in 5801f95
refactor to
pacta.scenario.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/358 and usenot going to do this until after a switch to pacta.scenario.data.preparation is madepacta.data.preparation::prepare_scenarios_long()
#209)workflow.data.preparation/run_pacta_data_preparation.R
Lines 196 to 213 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/348)workflow.data.preparation/run_pacta_data_preparation.R
Lines 260 to 270 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/360 and Usepacta.data.preparation::prepare_masterdata_debt()
#211)workflow.data.preparation/run_pacta_data_preparation.R
Lines 291 to 320 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/348 and https://github.com/RMI-PACTA/pacta.data.preparation/pull/353)workflow.data.preparation/run_pacta_data_preparation.R
Lines 350 to 370 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/348 and https://github.com/RMI-PACTA/pacta.data.preparation/pull/353)workflow.data.preparation/run_pacta_data_preparation.R
Lines 375 to 403 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/351)workflow.data.preparation/run_pacta_data_preparation.R
Lines 421 to 441 in 5801f95
refactor to
pacta.data.prepartion
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/352)workflow.data.preparation/run_pacta_data_preparation.R
Lines 453 to 476 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/348)workflow.data.preparation/run_pacta_data_preparation.R
Lines 489 to 496 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/361 and use new ISS prep functions #213)workflow.data.preparation/run_pacta_data_preparation.R
Lines 502 to 533 in 5801f95
refactor to
pacta.data.preparation
(done in https://github.com/RMI-PACTA/pacta.data.preparation/pull/361 and use new ISS prep functions #213)workflow.data.preparation/run_pacta_data_preparation.R
Lines 547 to 563 in 5801f95
AB#10388
The text was updated successfully, but these errors were encountered: