Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current scenario bar from techmix #525

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented Dec 8, 2023

Closes #513

In this PR I add a filter to techmix prep function so that it filters out the scenario bar for start year. I did not keep the option to display the scenario bar in the current year as it does not make much sense to look at scenario in the start year as it is always equal to the portfolio.

@MonikaFu MonikaFu self-assigned this Dec 8, 2023
Copy link
Contributor

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@MonikaFu MonikaFu merged commit ab0bb24 into main Dec 13, 2023
22 checks passed
@MonikaFu MonikaFu deleted the 513-remove-current-scen-bar-techmix branch December 13, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove scenario target in the "current year" of analysis
3 participants