Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upkeep: update unit tests based on changes in r2dii.data::nace_classification #464

Merged
merged 3 commits into from
Mar 22, 2024
Merged

upkeep: update unit tests based on changes in r2dii.data::nace_classification #464

merged 3 commits into from
Mar 22, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Mar 22, 2024

This PR changes some unit test expectations on r2dii.data to adapt to new classification code format of nace_classification in r2dii.data.

While I was there, I removed the dependence on loanbook_demo for a few tests which helps with #392
Relates to RMI-PACTA/r2dii.data#365

@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Mar 22, 2024
@jdhoffa jdhoffa requested review from jacobvjk and cjyetman March 22, 2024 08:41
@jdhoffa jdhoffa merged commit c2d3dab into main Mar 22, 2024
24 checks passed
@jdhoffa jdhoffa deleted the update_based_on_r2dii branch March 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyetman cjyetman cjyetman approved these changes

@jacobvjk jacobvjk Awaiting requested review from jacobvjk jacobvjk is a code owner

Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdhoffa @cjyetman