Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abcd_demo and loanbook_demo gain (FAKE!!!) LEIs #354

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Mar 14, 2024

Relates to RMI-PACTA/r2dii.match#460
Closes #349

Note, with the new dev join_id functionality or match_name, this now works nicely:

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(r2dii.data)
library(r2dii.match)

match_name(
  loanbook_demo,
  abcd_demo,
  join_id = c(lei_direct_loantaker = "lei")
) |> 
  filter(
  source == "id joined"
)
#> Warning: Some `sector_classification_direct_loantaker` are unknown:
#> NA
#> Some `sector_classification_direct_loantaker` are unknown:
#> NA
#> # A tibble: 117 × 28
#>    id_loan id_direct_loantaker name_direct_loantaker      id_intermediate_pare…¹
#>    <chr>   <chr>               <chr>                      <chr>                 
#>  1 L3      C292                Rowe-Rowe                  IP5                   
#>  2 L6      C304                Kassulke-Kassulke          <NA>                  
#>  3 L11     C309                Donnelly and Sons          <NA>                  
#>  4 L12     C298                Longo-Longo s.r.l.         <NA>                  
#>  5 L13     C297                Ladeck                     <NA>                  
#>  6 L14     C296                Gallo e figli              <NA>                  
#>  7 L15     C295                Silvestri, Silvestri e Si… <NA>                  
#>  8 L18     C284                Mariani, Mariani e Marian… <NA>                  
#>  9 L21     C286                Gallo Group                <NA>                  
#> 10 L23     C283                Bahringer-Bahringer        <NA>                  
#> # ℹ 107 more rows
#> # ℹ abbreviated name: ¹​id_intermediate_parent_1
#> # ℹ 24 more variables: name_intermediate_parent_1 <chr>,
#> #   id_ultimate_parent <chr>, name_ultimate_parent <chr>,
#> #   loan_size_outstanding <dbl>, loan_size_outstanding_currency <chr>,
#> #   loan_size_credit_limit <dbl>, loan_size_credit_limit_currency <chr>,
#> #   sector_classification_system <chr>, …

Created on 2024-03-14 with reprex v2.1.0

@jdhoffa jdhoffa requested a review from jacobvjk March 14, 2024 12:58
@jdhoffa jdhoffa changed the title feat: abcd_demo and loanbook_demo gain LEIs feat: abcd_demo and loanbook_demo gain (FAKE!!!) LEIs Mar 14, 2024
@jdhoffa jdhoffa requested a review from cjyetman March 15, 2024 07:45
@jdhoffa jdhoffa merged commit c88c405 into main Mar 15, 2024
24 checks passed
@jdhoffa jdhoffa deleted the 349-gain_sample_leis branch March 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: loanbook_demo and abcd_demo have no non-NA values for lei_direct_loantaker or lei respectively
2 participants