upkeep: add_green_technologies_to_abcd only adds techs if they are not already there
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a separate PR, I noticed some odd behaviour of this internal function.
The point of
add_green_technologies_to_abcdis to add green technologies to a matched input dataset if they are not already present. This serves to ensure that green technologies always get a forward-looking target (as is the expectation of SMSP).However, this function was erroneously adding the technologies no matter what (even if they were already present in the input). I guess this problem was evened out somewhere else in some call to
summarize, but I figured it makes sense to just fix it where it happens.See #318 for more info.
No related issue.