Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS file #452

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add CODEOWNERS file #452

merged 1 commit into from
Jan 25, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 24, 2024

@jacobvjk
Copy link
Member

@jdhoffa should we care about the failed check?

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 25, 2024

@jdhoffa should we care about the failed check?

We should, but not here. This PR does not affect it.

The render readme action seems to be broken. There is a conversation happening in parallel about it here:
RMI-PACTA/actions#11

I think in the future this kind of thing will fall in that repos domain, so not worrying about it here :-)

jacobvjk
jacobvjk reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobvjk jacobvjk self-requested a review January 25, 2024 12:12
@jdhoffa jdhoffa merged commit abc869c into main Jan 25, 2024
24 of 25 checks passed
@jdhoffa jdhoffa deleted the add_code_owner branch January 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

@AlexAxthelm AlexAxthelm Awaiting requested review from AlexAxthelm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdhoffa @jacobvjk