Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export_manifest function #3

Merged
merged 172 commits into from
Apr 25, 2024
Merged

Add export_manifest function #3

merged 172 commits into from
Apr 25, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented Mar 12, 2024 •
edited
Loading

currently exports an empty list

TODO:

  • File info
  • Session info
    • Dependencies
    • R Info
    • envvars?
  • Git repo info
  • arbitrary workflow info
  • workflow package version
  • config
  • timestamp

Closes #1
Closes #7

@AlexAxthelm
Add export_manifest function
7310f25 
currently exports an empty list
@AlexAxthelm AlexAxthelm marked this pull request as draft March 12, 2024 15:54
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@AlexAxthelm
Add file metadata functions
ae6e425
@AlexAxthelm
Update docs
71ef70a
@AlexAxthelm
bump dev version
bc1d483
@AlexAxthelm
add digest dependency
f216efa
@AlexAxthelm
add .github directory to Rbuildignore
ef1f149
@AlexAxthelm
Define log formatter for package
e95981f
@AlexAxthelm
Add .lintr config
9af1650
@AlexAxthelm
feat(app): #1 improve handling of metadata summary for unknown filetypes
c37466b
@AlexAxthelm
test(app): #1 Add tests for single file metadata
3fe4b56
@AlexAxthelm
test(app): #1 Suppress logging output during tests
08ed2b0
@AlexAxthelm
Add summary metadata support for JSON
cc7efc5
@AlexAxthelm
Add handling for missing files
0f5ec4f
@AlexAxthelm
Move logger setup into test file
ed4c6d0
@AlexAxthelm
import logger functions
f038252
@AlexAxthelm
Fix test for logging missing file error
7c2fd54
@AlexAxthelm
shorten line
cd71fe4
@AlexAxthelm
Remove testing for log output
86607a9
@AlexAxthelm
use actual digests, rather than hardcoded values
e8f25ff 
`saveRDS` is producing different digest on different systems
@AlexAxthelm
Update Rbuildignore
bd312ef
@AlexAxthelm
add more tests for error cases
7c59bd0
@AlexAxthelm
Rename variables for consistency
14f5514
@AlexAxthelm
Check for actual filesize, rather than hardcoding
ada5480 
caused errors on varying systems
@AlexAxthelm
remove trailing line
715ee07
@AlexAxthelm
Add tests for get_file_metadata()
1163c93
@AlexAxthelm
Add more tests
d26f58b
@AlexAxthelm
Add test for empty file
44aded2
@AlexAxthelm
update filesize check in tests
bb34626
@AlexAxthelm AlexAxthelm marked this pull request as ready for review April 23, 2024 15:56
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa April 23, 2024 15:56
@AlexAxthelm AlexAxthelm self-assigned this Apr 23, 2024
cjyetman
cjyetman reviewed Apr 24, 2024
View reviewed changes
R/export_manifest.R Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed Apr 24, 2024
View reviewed changes
R/get_file_metadata.R Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed Apr 24, 2024
View reviewed changes
R/get_file_metadata.R Outdated Show resolved Hide resolved
cjyetman
cjyetman previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@cjyetman cjyetman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just made a few nit comments. The tests kinda made my head spin, so I didn't review them closely.

jdhoffa
jdhoffa previously approved these changes Apr 24, 2024
View reviewed changes
@AlexAxthelm AlexAxthelm dismissed stale reviews from cjyetman and jdhoffa via 968358c April 24, 2024 10:25
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa April 24, 2024 15:04
jdhoffa
jdhoffa approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexAxthelm AlexAxthelm merged commit c47b28c into main Apr 25, 2024
15 checks passed
@AlexAxthelm AlexAxthelm deleted the feat/1-export-manifests branch April 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman cjyetman approved these changes

Assignees

@AlexAxthelm AlexAxthelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture git status for locally loaded REPOs Add function to standardize manifest export
3 participants
@AlexAxthelm @cjyetman @jdhoffa