Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes found during integration with workflow.pacta #13

Merged
merged 3 commits into from
May 28, 2024
Merged

Fixes found during integration with workflow.pacta #13

merged 3 commits into from
May 28, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented May 24, 2024 •
edited
Loading

Fixes found while working on RMI-PACTA/workflow.pacta#64

  • 0718c4c: Handling for JSON strings that are read in as character vectors, rather than single strings. The file.exists check for reading from file was erroring when the json object had length greater than 1.

@AlexAxthelm AlexAxthelm changed the title Add handling for JSON vectors Fixes found during integration with workflow.pacta May 24, 2024
@AlexAxthelm AlexAxthelm mentioned this pull request May 24, 2024
Merged
2 tasks
@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 28, 2024 08:47
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa May 28, 2024 08:47
@AlexAxthelm AlexAxthelm merged commit 7dfd6fb into main May 28, 2024
15 checks passed
@AlexAxthelm AlexAxthelm deleted the fix/integration-issues-with-worfklow.pacta branch May 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa