Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge lists #10

Merged
merged 7 commits into from
May 15, 2024
Merged

merge lists #10

merged 7 commits into from
May 15, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

@AlexAxthelm AlexAxthelm commented May 10, 2024

Add functions to handle merging lists recursively (similar to config::merge, but with tests, and no dependency).

@AlexAxthelm AlexAxthelm marked this pull request as draft May 10, 2024 16:30
@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 10, 2024 17:06
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa May 10, 2024 17:06
@AlexAxthelm AlexAxthelm marked this pull request as draft May 13, 2024 11:00
@AlexAxthelm AlexAxthelm changed the title Feat/2 parse json configs merge lists May 14, 2024
@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 14, 2024 12:55
jdhoffa
jdhoffa previously approved these changes May 15, 2024
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool!

R/merge_lists.R Outdated Show resolved Hide resolved
R/merge_lists.R Outdated Show resolved Hide resolved
@jdhoffa
Copy link
Member

jdhoffa commented May 15, 2024

Some NB comments and typos, but functionally looks good!

@AlexAxthelm AlexAxthelm requested a review from jdhoffa May 15, 2024 14:21
@AlexAxthelm AlexAxthelm merged commit 97306af into main May 15, 2024
15 checks passed
@AlexAxthelm AlexAxthelm deleted the feat/2-parse-json-configs branch May 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants