Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks on repo status #13

Merged
merged 19 commits into from
Apr 10, 2024
Merged

Add more checks on repo status #13

merged 19 commits into from
Apr 10, 2024

Conversation

AlexAxthelm
Copy link
Contributor

Big additions here:

  • Lists of "prod" vs "experimental" workflows/repos
  • Function to check if a given repo is a dependency of a package on those lists (allows us to know if something is prod-critical or not)
  • Get name of codeowner (from CODEOWNERS file) and if codeowners file has errors

@AlexAxthelm AlexAxthelm requested a review from jdhoffa March 27, 2024 14:50
@AlexAxthelm
Copy link
Contributor Author

AlexAxthelm commented Mar 27, 2024

Work to continue:

  • Check for workflows
  • Check for rulesets
  • include license in output

@jdhoffa
Copy link
Member

jdhoffa commented Mar 27, 2024

What would a CODEOWNERS error look like?

@AlexAxthelm
Copy link
Contributor Author

What would a CODEOWNERS error look like?

The easiest way to get one is to misformat the CODEOWNERS file, but more generally laid out here: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-codeowners-errors

@jdhoffa
Copy link
Member

jdhoffa commented Mar 27, 2024

Hey @AlexAxthelm let me know if you want me to re-review?
This looks good but seems like you're still working on it

@AlexAxthelm AlexAxthelm marked this pull request as draft March 27, 2024 20:15
@AlexAxthelm
Copy link
Contributor Author

AlexAxthelm commented Mar 27, 2024

Yeah, still puttering on this for a little more. marking as draft. Added a check that the repo is using the standard RMI-PACTA/actions workflows.

TODO:

  • check that expected workflows are expected (R.yml for R, docker.yml if a dockerfile is present)
  • Rulesets

@AlexAxthelm AlexAxthelm requested a review from jdhoffa March 28, 2024 13:34
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 270 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2992532) to head (3a2a783).
Report is 3 commits behind head on main.

❗ Current head 3a2a783 differs from pull request most recent head ab3be6b. Consider uploading reports for the commit ab3be6b to get more accurate results

Files Patch % Lines
R/workflows.R 0.00% 65 Missing ⚠️
R/rulesets.R 0.00% 60 Missing ⚠️
R/get_gh_file.R 0.00% 36 Missing ⚠️
R/prod_checks.R 0.00% 34 Missing ⚠️
R/dependencies.R 0.00% 29 Missing ⚠️
R/codeowners.R 0.00% 25 Missing ⚠️
R/get_repos.R 0.00% 12 Missing ⚠️
R/utils.R 0.00% 7 Missing ⚠️
R/generate_package_table.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #13    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          1       9     +8     
  Lines         87     338   +251     
======================================
- Misses        87     338   +251     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm marked this pull request as ready for review April 9, 2024 15:51
@AlexAxthelm
Copy link
Contributor Author

@jdhoffa Ready for review. There's a byunch of utilities here that you can feel free to integrate or not as you see fit.

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntactically it looks good, but I got a weird error when trying to source the github-repos.Rmd file, which I suppose is the main use-case of this repo?

Not sure if there's some weirdness when it tries to fetch info on it's own repo?

inst/extdata/github-repos.Rmd Show resolved Hide resolved
@jdhoffa jdhoffa self-requested a review April 10, 2024 10:19
@jdhoffa jdhoffa merged commit a258cd3 into main Apr 10, 2024
15 checks passed
@jdhoffa jdhoffa deleted the repo-status branch April 10, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants