Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/48 remove globalenv #49

Merged
merged 9 commits into from
May 28, 2024
Merged

Fix/48 remove globalenv #49

merged 9 commits into from
May 28, 2024

Conversation

AlexAxthelm
Copy link
Collaborator

Closes #48

@codecov Codecov
Copy link

codecov bot commented May 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 60.09%. Comparing base (384e220) to head (50a9159).

Files Patch % Lines
R/get_abcd_raw.R 0.00% 4 Missing ⚠️
R/merge_in_geography.R 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files          19       19           
  Lines         431      431           
=======================================
  Hits          259      259           
  Misses        172      172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexAxthelm AlexAxthelm mentioned this pull request May 27, 2024
Merged
@AlexAxthelm
Copy link
Collaborator Author

Runs cleanly in workflow.pacta, after some code changes. https://github.com/RMI-PACTA/workflow.pacta/actions/runs/9257776713/job/25466670195?pr=64

@AlexAxthelm AlexAxthelm mentioned this pull request May 27, 2024
Merged
2 tasks
@AlexAxthelm
Copy link
Collaborator Author

Changes in workflow.transition.monitor also run cleanly https://github.com/RMI-PACTA/workflow.transition.monitor/actions/runs/9258060506

RMI-PACTA/workflow.transition.monitor#316

@AlexAxthelm AlexAxthelm marked this pull request as ready for review May 27, 2024 18:10
@AlexAxthelm AlexAxthelm requested a review from cjyetman as a code owner May 27, 2024 18:10
@AlexAxthelm AlexAxthelm requested a review from jdhoffa May 27, 2024 18:10
cjyetman
cjyetman reviewed May 28, 2024
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed May 28, 2024
View reviewed changes
R/get_abcd_raw.R Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed May 28, 2024
View reviewed changes
R/get_abcd_raw.R Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed May 28, 2024
View reviewed changes
R/get_abcd_raw.R Outdated Show resolved Hide resolved
cjyetman
cjyetman reviewed May 28, 2024
View reviewed changes
R/get_abcd_raw.R Outdated Show resolved Hide resolved
cjyetman
cjyetman requested changes May 28, 2024
View reviewed changes
Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

AlexAxthelm and others added 3 commits May 28, 2024 09:48
@AlexAxthelm @cjyetman
Use analysis_inputs_path as var name
0bdbac8 
Suggestions from Code review, @cjyetman

Co-authored-by: CJ Yetman <[email protected]>
@AlexAxthelm @cjyetman
Revert version bump
ddb3019 
Co-authored-by: CJ Yetman <[email protected]>
@AlexAxthelm
Render documentation
50a9159
@AlexAxthelm AlexAxthelm requested a review from cjyetman May 28, 2024 07:57
@AlexAxthelm AlexAxthelm merged commit 59dedef into main May 28, 2024
9 checks passed
@AlexAxthelm AlexAxthelm deleted the fix/48-remove-globalenv branch May 28, 2024 10:08
AlexAxthelm added a commit to RMI-PACTA/workflow.pacta that referenced this pull request May 28, 2024
@AlexAxthelm
Use main branch for allocate
85a69d5 
RMI-PACTA/pacta.portfolio.allocate#49 is merged
AlexAxthelm added a commit to RMI-PACTA/workflow.pacta that referenced this pull request May 28, 2024
@AlexAxthelm
Adapt to signature change in function
ef84c03 
from late revision in RMI-PACTA/pacta.portfolio.allocate#49

Specifically RMI-PACTA/pacta.portfolio.allocate@0bdbac8
@AlexAxthelm AlexAxthelm mentioned this pull request May 30, 2024
Closed
AlexAxthelm added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request May 30, 2024
@AlexAxthelm
Revert dependency to main
187480d 
Following merge of RMI-PACTA/pacta.portfolio.allocate#49
AlexAxthelm added a commit to RMI-PACTA/workflow.transition.monitor that referenced this pull request May 30, 2024
@AlexAxthelm
adapt to new function signatures in pacta.portfolio.allocate (#316)
26473e5 
Adapting to
RMI-PACTA/pacta.portfolio.allocate#49

Depends on and incorporates changes needed for
RMI-PACTA/pacta.portfolio.allocate#49

CLoses #317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_abcd_raw and merge_in_geography reference .GlobalEnv
3 participants
@AlexAxthelm @cjyetman @jdhoffa