Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data dictionary #89

Merged
merged 18 commits into from
Sep 4, 2024
Merged

Data dictionary #89

merged 18 commits into from
Sep 4, 2024

Conversation

jacobvjk
Copy link
Member

@jacobvjk jacobvjk commented Aug 26, 2024

closes #50

  • gains data_dictionary, which documents and explains the data structure of all outputs
  • gains vignette data_ditionary.Rmd which provides some context for each output data set and shows the corresponding entry of the data dictionary in a DT::datatable

NOTE:

  • column width is far from ideal in the vignette, but I wanted to get the content out first

@jacobvjk
Copy link
Member Author

jacobvjk commented Sep 2, 2024

@cjyetman @AlexAxthelm I am a bit unsure why the R-CMD check gets hung up over no visible binding of internal data files. My understanding is that internal data should be available without further calls needed. That's how I interpret this at least: https://r-pkgs.org/data.html#sec-data-sysdata
Also seems to work in other packages, e.g. in pacta.multi.loanbook.analysis. Any idea what I am missing here?

@cjyetman
Copy link
Member

cjyetman commented Sep 3, 2024

@cjyetman @AlexAxthelm I am a bit unsure why the R-CMD check gets hung up over no visible binding of internal data files. My understanding is that internal data should be available without further calls needed. That's how I interpret this at least: https://r-pkgs.org/data.html#sec-data-sysdata Also seems to work in other packages, e.g. in pacta.multi.loanbook.analysis. Any idea what I am missing here?

I think R/sysdata.rda doesn't have the objects in it yet, you just have to run data-raw/auxiliary_data_sets.R first

e.g.

(load("~/github/rmi-pacta/workflow.multi.loanbook/R/sysdata.rda"))
#> [1] "data_dictionary"

@jacobvjk
Copy link
Member Author

jacobvjk commented Sep 3, 2024

@cjyetman @AlexAxthelm I am a bit unsure why the R-CMD check gets hung up over no visible binding of internal data files. My understanding is that internal data should be available without further calls needed. That's how I interpret this at least: https://r-pkgs.org/data.html#sec-data-sysdata Also seems to work in other packages, e.g. in pacta.multi.loanbook.analysis. Any idea what I am missing here?

I think R/sysdata.rda doesn't have the objects in it yet, you just have to run data-raw/auxiliary_data_sets.R first

e.g.

(load("~/github/rmi-pacta/workflow.multi.loanbook/R/sysdata.rda"))
#> [1] "data_dictionary"

huh correct.. this is a case of "never assume" I guess

@jacobvjk jacobvjk marked this pull request as ready for review September 4, 2024 09:45
@jacobvjk jacobvjk requested a review from cjyetman September 4, 2024 09:46
@cjyetman cjyetman self-requested a review September 4, 2024 10:06
cjyetman
cjyetman previously approved these changes Sep 4, 2024
@cjyetman cjyetman dismissed their stale review September 4, 2024 10:08

did you commit the new sysdata.rda?

Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... I was skeptical because the dif file viewer said that sysdata.rda only changed 9 Bytes, but I just ran it locally as is and it seems to be fine

@cjyetman cjyetman merged commit 5d291f2 into main Sep 4, 2024
9 checks passed
@cjyetman cjyetman deleted the data-dictionary branch September 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: gains data dictionary
2 participants