Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom stop and warn messages with cli versions #68

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

cjyetman
Copy link
Member

No description provided.

@cjyetman cjyetman requested a review from jacobvjk as a code owner August 18, 2024 10:42
@cjyetman cjyetman marked this pull request as draft August 18, 2024 21:02
@cjyetman cjyetman marked this pull request as ready for review August 19, 2024 06:52
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly see comment on the error message

R/run_match_prioritize.R Outdated Show resolved Hide resolved
R/stop_if_.R Outdated Show resolved Hide resolved
@cjyetman cjyetman requested a review from jacobvjk August 19, 2024 10:58
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjyetman cjyetman merged commit 1321707 into main Aug 19, 2024
9 checks passed
@cjyetman cjyetman deleted the custom-msgs-with-cli branch August 19, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants